bucky/url-shortener
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

invalid-urls #18

Merged
bucky merged 5 commits from invalid-urls into master 2023-10-07 21:13:54 -07:00
Conversation 1 Commits 5 Files Changed 3
+23 -3
bucky commented 2023-10-07 21:13:47 -07:00
Owner
Copy Link
Copy Source

refactored invalid urls to instead stay on the current page, with a 404 status code, and include the form to create a new url.

refactored invalid urls to instead stay on the current page, with a 404 status code, and include the form to create a new url.
bucky added 5 commits 2023-10-07 21:13:48 -07:00
added new scenario beb9b0c14a
use the correct clause format since staying on site b97ee3f3bb
check if the link exists, redirects home if it doesn't f8499a79c2
update for missing link scenario c7fee27623 
+ if the link isn't found, don't redirect it, keep it on the same page
+ it should have a status code of 404
+ it should have the form fields as well

+ added page status check
refactored missing link scenario to make more sense 5bce31baf2 
+ 404 code, stay on the current page, and load the form
+ also simplified the logic for the create action if the link doesn't
  already exist
bucky merged commit e6cc0959a4 into master 2023-10-07 21:13:54 -07:00
bucky deleted branch invalid-urls 2023-10-07 21:13:54 -07:00
bucky commented 2023-10-07 21:14:27 -07:00
Author
Owner
Copy Link
Copy Source

this PR closes bucky/url-shortener#8

this PR closes bucky/url-shortener#8
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jenkins mrheffern bucky
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bucky/url-shortener#18
Delete Branch "invalid-urls"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?